-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change react-native-video to a peer dependency with any version required #1070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you figured out why tests not working anymore?
Only way to allow video playback on Android
Codecov Report
@@ Coverage Diff @@
## master #1070 +/- ##
==========================================
+ Coverage 43.1% 85.71% +42.6%
==========================================
Files 21 3 -18
Lines 515 14 -501
Branches 112 3 -109
==========================================
- Hits 222 12 -210
+ Misses 221 2 -219
+ Partials 72 0 -72
Continue to review full report at Codecov.
|
I'm actually working on some additional improvements to this right now, so I'm going to let it sit for now. For example, there's currently no way to control the video on android! So I'm either going to pull in react-native-video-controls or allow a custom video player prop to be passed into the video message object. |
I'm going to re-open or create a new one when I have a complete solution. |
I've worked at the same task today (controls in Android) and kicked "react-native-video-controls" because it is outdated - even like Finally I've figured out, that you now can handle video-controls by react-native-video. TheWidlarzGroup/react-native-video#1414 Would really appreciate if you will continuou your work on this "peer dependency" topic.. |
@xstable - I have fixed the play-button issue and committed the same today in the above mentioned PR. If you needed you can try using patch-package . Thanks. |
@xstable @IbrahimSulai I have a new PR opened with this: Also, you can already pass a custom video component in. My PR updates the documentation to reflect this as well. I use react-native-video-controls as my control view on Android and it works fine. |
@ahartzog forget my previous post. I've used patch-package but didn't notice, that it don't be able to patch the package.json. @xcarpentier So hopefully it will be merged soon. |
Including react-native-video as a dependancy at ^3.2.1 caused a conflict with our existing usage of react-native-video. Error was: "Tried to register two views with the same name RCTVideo".
Changing react-native-video to a peer dependency resolves this issue.
I've also confirmed that the video feature works fine with the newest version of react-native-video.
We could alternatively set it as a peer dependency with version 3.x as well?